Skip to content

Conversation

Zalathar
Copy link
Contributor

HTML files were needed for testing -Z dump-mir-spanview, but that flag has been removed by #119566.

HTML files were needed for testing `-Z dump-mir-spanview`, but that flag has
been removed by rust-lang#119566.
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2024

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 16, 2024
@Zalathar
Copy link
Contributor Author

I manually tested this by cherry-picking some of the test files removed by #119566 and running x tidy.

Doing that prompted me to improve the error message a little bit as well.

@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 16, 2024

📌 Commit 40166c8 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#118361 (stabilise bound_map)
 - rust-lang#119816 (Define hidden types in confirmation)
 - rust-lang#119900 (Inline `check_closure`, simplify `deduce_sig_from_projection`)
 - rust-lang#119969 (Simplify `closure_env_ty` and `closure_env_param`)
 - rust-lang#119990 (Add private `NonZero<T>` type alias.)
 - rust-lang#119998 (Update books)
 - rust-lang#120002 (Lint `overlapping_ranges_endpoints` directly instead of collecting into a Vec)
 - rust-lang#120018 (Don't allow `.html` files in `tests/mir-opt/`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9154410 into rust-lang:master Jan 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2024
Rollup merge of rust-lang#120018 - Zalathar:mir-opt-html, r=Nilstrieb

Don't allow `.html` files in `tests/mir-opt/`

HTML files were needed for testing `-Z dump-mir-spanview`, but that flag has been removed by rust-lang#119566.
@rustbot rustbot added this to the 1.77.0 milestone Jan 16, 2024
@Zalathar Zalathar deleted the mir-opt-html branch January 16, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants